[FFmpeg-devel] [PATCH v5] Add support for Audible AAX (and AAX+) files

[Vesselin Bontchev]

18.07.2015, 13:03, "Paul B Mahol" <onemda at gmail.com>:
> Dana 18. 7. 2015. 11:46 osoba "Vesselin Bontchev" <
> vesselin.bontchev at yandex.com> napisala je:
>>  18.07.2015, 01:45, "Michael Niedermayer" <michael at niedermayer.cc>:
>>  > On Thu, Jul 16, 2015 at 03:57:26AM +0300, Vesselin Bontchev wrote:
>>  >> + // extracted from libAAX_SDK.so and AAXSDKWin.dll files!
>>  >
>>  >> + uint8_t fixed_key[] = { 0x77, 0x21, 0x4d, 0x4b, 0x19, 0x6a, 0x87,
>>  >
>>  > I think this should not be hardcoded but provided by the user via
>>  > an AVOption.
>>
>>  I fear that doing this will impact the usability negatively. Are there
>>  strong reasons for suggesting this change?

> Using AVOption will set default key to what is already now hardcoded.

Thanks for explaining this! I have now uploaded a new revision (v6) of the patch, which uses an AVOption.

Vesselin