[FFmpeg-devel] [PATCH 2/4] libavcodec/qsvdec_h264.c: refactoring: functional of qsv_process_data() has been moved into qsvdec.c

[Michael Niedermayer]

On Thu, Jul 23, 2015 at 12:26:40PM +0300, Ivan Uskov wrote:
> Hello Michael,
> 
> I have replaced 'ready' flag name to 'engine_ready' and added
> a corresponded comment.
> Regarding ff_qsv_prepare() looks like it is need not at all, I have
> modified ff_qsv_decode_init() instead. So patch become even simple,
> thank.
> 
> Please review.
> 
> NOTE
> The ff_qsv_decode_init() should be another subject of refactoring, it
> should be split at least to 3 parts:
> -qsv/mfx session creation (common with qsvenc.c so this part  should be moved
> to qsv.c or qsv_internal.c)
> -header detection (because it calls several times in common case and
> here can be a necessity to re-detect sequence header on a fly)
> -encoder creation.
> But I plan to take it some later, currently I have got couple critical
> bug fixes in my queue of patches.
> 
> Thursday, July 23, 2015, 4:18:13 AM, you wrote:
> 
> 
> >> +    int ready;
> 
> MN> I think this should be documented, its not immedeatly clear from
> MN> just the name "ready" what exactly it refers to
> MN> maybe a more verbose variable name would make it also more immedeatly
> MN> obvious what it means
> 
> MN> maybe something like
> MN> "int prepared" and ff_qsv_prepare() but maybe that is not the
> MN> best suggestion i dont know
> 
> MN> also ff_qsv_prepare() should be documented what it exactly does/means
> 
> MN> [...]
> 
> 
> 
> 
> -- 
> Best regards,
>  Ivan                            mailto:ivan.uskov at nablet.com

>  qsvdec.c      |   13 ++++++++++++-
>  qsvdec.h      |    4 ++++
>  qsvdec_h264.c |   20 +-------------------
>  3 files changed, 17 insertions(+), 20 deletions(-)
> 10538a4576fe91c371a5d45f94951925047cbf80  0001-libavcodec-qsvdec_h264.c-refactoring-functional-of-q.patch
> From 7c5f9b706132428c531f9b4b9774e4a495825245 Mon Sep 17 00:00:00 2001
> From: Ivan Uskov <ivan.uskov at nablet.com>
> Date: Thu, 23 Jul 2015 05:14:41 -0400
> Subject: [PATCH] libavcodec/qsvdec_h264.c: refactoring: functional of
>  qsv_process_data() has been moved into qsvdec.c
> 
> ---
>  libavcodec/qsvdec.c      | 13 ++++++++++++-
>  libavcodec/qsvdec.h      |  4 ++++
>  libavcodec/qsvdec_h264.c | 20 +-------------------
>  3 files changed, 17 insertions(+), 20 deletions(-)

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150723/cd10ae61/attachment.sig>