[FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for VP9 bilinear functions

Michael Niedermayer michael at niedermayer.cc
Mon Jul 27 17:25:15 CEST 2015


On Mon, Jul 27, 2015 at 02:11:58PM +0000, Shivraj Patil wrote:
> 
> Hi,
> 
> On Mon, Jul 27, 2015 at 7:59 AM, <shivraj.patil at imgtec.com<mailto:shivraj.patil at imgtec.com>> wrote:
> From: Shivraj Patil <shivraj.patil at imgtec.com<mailto:shivraj.patil at imgtec.com>>
> 
> Signed-off-by: Shivraj Patil <shivraj.patil at imgtec.com<mailto:shivraj.patil at imgtec.com>>
> ---
>  libavcodec/mips/vp9_mc_msa.c       | 2123 ++++++++++++++++++++++++++++++++++++
>  libavcodec/mips/vp9dsp_init_mips.c |    2 +
>  libavcodec/mips/vp9dsp_mips.h      |   32 +
>  3 files changed, 2157 insertions(+)
> [..]
> +void ff_avg_bilin_4h_msa(uint8_t *dst, ptrdiff_t dst_stride,
> +                         const uint8_t *src, ptrdiff_t src_stride,
> +                         int height, int mx, int my)
> +{
> +    const int8_t *filter = vp9_bilinear_filters_msa[mx - 1];
> +
> +    if (4 == height) {
> +        common_hz_2t_and_aver_dst_4x4_msa(src, src_stride, dst, dst_stride,
> +                                          filter);
> +    } else if (8 == height) {
> +        common_hz_2t_and_aver_dst_4x8_msa(src, src_stride, dst, dst_stride,
> +                                          filter);
> +    }
> +}
> 
> You're using this construct in various places, how much does it help?
> 
> (Otherwise no comments, basically lgtm % the above.)

applied

thanks


> 
> 
> Shivraj:- For 8 height case, it helps to reduce stalls (perf gain ~20%), as compared to calling 4 height function twice.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150727/ce0642ae/attachment.sig>


More information about the ffmpeg-devel mailing list