[FFmpeg-devel] [PATCH 13/14] tests: Add aac_fixed decoder test

[Michael Niedermayer]

On Mon, Jun 01, 2015 at 01:46:32PM +0000, Nedeljko Babic wrote:
> >On Fri, May 29, 2015 at 03:46:32PM +0200, Nedeljko Babic wrote:
> >> Signed-off-by: Nedeljko Babic <nedeljko.babic at imgtec.com>
> >> ---
> >>  tests/fate/aac.mak | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >>  1 file changed, 57 insertions(+), 1 deletion(-)
> >
> >These tests do not all pass:
> >
> >tests/data/fate/aac-fixed-al_sbr_hq_cm_48_2.err:Assertion (int32_t)((a.mant * (int64_t)b.mant) >> 29) == (a.mant * (int64_t)b.mant) >> 29 failed at ./>libavutil/softfloat.h:93>
> >tests/data/fate/aac-fixed-al_sbr_hq_cm_48_5.1.err:Assertion (int32_t)((a.mant * (int64_t)b.mant) >> 29) == (a.mant * (int64_t)b.mant) >> 29 failed at >./>libavutil/softfloat.h:93
> >tests/data/fate/aac-fixed-al_sbr_hq_sr_48_2_fsaac48.err:Assertion a.mant < 0x40000000 && a.mant > -0x40000000 failed at ./libavutil/softfloat.h:75
> 
> I cannot reproduce a problem.
> 
> I am running this on two x86 machines, one with Ubuntu 14.04 and the other with the Red Hat 4.1.2-51.
> 
> Configuration that I am using is:
> ./configure --samples=../fate_tests --enable-gpl --enable-memory-poisoning --enable-avresample --enable-debug=2 --disable-iconv --target-os=linux --disable-yasm

probably needs --assert-level=2

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150601/61a75f03/attachment.asc>