[FFmpeg-devel] [PATCH] libavutil/doc: Changes in documentation due to changes to fixed_dsp

[Michael Niedermayer]

On Fri, Jun 05, 2015 at 08:05:33PM +0200, Michael Niedermayer wrote:
> On Fri, Jun 05, 2015 at 07:59:47PM +0200, Michael Niedermayer wrote:
> > On Fri, Jun 05, 2015 at 10:04:54AM -0400, Ronald S. Bultje wrote:
> > > Hi,
> > > 
> > > On Fri, Jun 5, 2015 at 5:54 AM, Nedeljko Babic <nedeljko.babic at imgtec.com>
> > > wrote:
> > > 
> > > > New functions are added to fixed_dsp, so the documentation is changed
> > > > accordingly.
> > > >
> > > > Signed-off-by: Nedeljko Babic <nedeljko.babic at imgtec.com>
> > > > ---
> > > >  doc/APIchanges      | 7 +++++++
> > > >  libavutil/version.h | 2 +-
> > > >  2 files changed, 8 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/doc/APIchanges b/doc/APIchanges
> > > > index 5c36dca..bcf4fe6 100644
> > > > --- a/doc/APIchanges
> > > > +++ b/doc/APIchanges
> > > > @@ -15,6 +15,13 @@ libavutil:     2014-08-09
> > > >
> > > >  API changes, most recent first:
> > > >
> > > > +2015-06-05 - xxxxxxx - lavu  54.27.101 - fixed_dsp.h
> > > > +  Add vector_fmul()
> > > > +  Add vector_fmul_reverse()
> > > > +  Add vector_fmul_add()
> > > > +  Add scalarproduct_fixed()
> > > > +  Add butterflies_fixed()
> > > 
> > > 
> > > These functions are not part of our public API, are they?
> > 
> > It appears that the header isnt installed currently, ill post a patch
> > to correct that
> 
> hmm, it seems thats not possible
> it contains
> #include "libavcodec/mathops.h"
> which is not a public header and from libavcodec
> 
> ill revert the addition to APIchanges
> 
> nedeljko, can you fix that header so it can be installed or move the
> content to libavcodec. Depending on what the people prefer

or as james pointed out on IRC
<jamrial> does it need to be installed for that matter? it's essentially the same as float_dsp, and that one has always been internal


i wonder if it shouldnt be renamed to AVPrivFixedDSPContext in that
case then though

anyway i have no strong oppinon on any of this, iam fine with any
solution

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150605/ae14defc/attachment.asc>