[FFmpeg-devel] [PATCH v3] * mpegts demuxer recognizes private streams on demand

[Michael Niedermayer]

On Wed, Jun 10, 2015 at 10:41:10PM +0200, Wolfgang Lorenz wrote:
> No answers?
> 
> Well, I do have a question.
> 
> Am Thu, 4 Jun 2015 23:46:21 +0200
> schrieb Wolfgang Lorenz <wl-chmw at gmx.de>:
> 
> > The option went into the MpegTSContext struct and can be addressed via
> > dictionary:
> > 
> >     AVFormatContext * formatContext = NULL;
> > 
> >     /* enable mpeg-ts private stream recognition */
> >     AVDictionary * dict = NULL;
> >     av_dict_set_int(&dict, "mpegts_recognize_private_streams", 1, 0);
> > 
> >     /* open file */
> >     avformat_open_input(&formatContext, fileName, NULL, &dict);
> > 
> > [...]
> 
> While I have used some kind of name scoping for the dictionary access,
> to avoid name clashes, I've seen, that this is not done for the rest of
> the formats. I think in most cases, this won't matter anyway. There are
> many doubling names between different input formats, but these won't
> make a problem, as one format context can only contain one input
> format. I've seen one name clash between AVFormatContext and an input
> format ("auto", mov.c), and "strict" seems to be declared twice for

constants have a scope limited to their type and field to which they
apply


> AVFormatContext. So, here's my question: Is there any kind of
> convention for naming options? And should I rename my option to
> "recognize_private_streams", or something different, to get the patch
> accepted? Recommendations are welcome.

i have no oppinon on the name, either is fine
what kept me from applying this is that i dont see why it has to
break detection of streams for which reliable detection exists,
it breaks at least fate-acodec-s302m and fate-dca-core

This should be a fallback for private streams which are not
identified by a strong probing method

ill post a patch which will do this in a moment, please comment/test

thanks


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150610/b8642252/attachment.asc>