[FFmpeg-devel] [PATCH 1/2] Set subtitle track dimensions for mov_text to display the subtitles properly

[Philip Langdale]

On 2015-06-11 00:42, Nicolas George wrote:
> Le tridi 23 prairial, an CCXXIII, Niklesh Lalwani a écrit :
>> From: Niklesh <niklesh.lalwani at iitb.ac.in>
>> 
>> This patch mostly replicates the concept patch posted by Philip 
>> https://ffmpeg.org/pipermail/ffmpeg-devel/2013-March/140299.html. This 
>> sets the proper dimensions for the subtitle tracks, by making use of 
>> the height and width of the video stream. The patch is exlained in 
>> detail in the link.
>> 
>> Signed-off-by: Niklesh <niklesh.lalwani at iitb.ac.in>
>> ---
>>  libavformat/movenc.c | 38 ++++++++++++++++++++++++++++++++++----
>>  libavformat/movenc.h |  4 ++++
>>  2 files changed, 38 insertions(+), 4 deletions(-)
> 
> I said it in the original thread and I say it again now: this is not 
> the
> proper place, it should happen in the encoder and the surrounding
> applications.

Yeah. I sent this to Niklesh to unblock his other work, but we need a 
proper
approach to setting the dimensions and this isn't it.

--phil