[FFmpeg-devel] [PATCH] libvpxenc: add color-space option for vp9

[James Zern]

On Tue, Jun 16, 2015 at 3:10 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Jun 15, 2015 at 10:43:17PM -0700, James Zern wrote:
>> [...]
>>
>> @@ -968,6 +979,17 @@ static const AVOption vp9_options[] = {
>>      { "variance",        "Variance based Aq",   0, AV_OPT_TYPE_CONST, {.i64 = 1}, 0, 0, VE, "aq_mode" },
>>      { "complexity",      "Complexity based Aq", 0, AV_OPT_TYPE_CONST, {.i64 = 2}, 0, 0, VE, "aq_mode" },
>>      { "cyclic",          "Cyclic Refresh Aq",   0, AV_OPT_TYPE_CONST, {.i64 = 3}, 0, 0, VE, "aq_mode" },
>> +#if HAVE_VP9_COLORSPACE_CONTROL
>> +    { "color-space",     "Input color space",                           OFFSET(colorspace),      AV_OPT_TYPE_INT, {.i64 = -1}, -1, 7, VE, "colorspace"},
>> +    { "unknown",         NULL, 0, AV_OPT_TYPE_CONST, {.i64 = VPX_CS_UNKNOWN},   0, 0, VE, "colorspace" },
>> +    { "bt601",           NULL, 0, AV_OPT_TYPE_CONST, {.i64 = VPX_CS_BT_601},    0, 0, VE, "colorspace" },
>> +    { "bt709",           NULL, 0, AV_OPT_TYPE_CONST, {.i64 = VPX_CS_BT_709},    0, 0, VE, "colorspace" },
>> +    { "smpte170",        NULL, 0, AV_OPT_TYPE_CONST, {.i64 = VPX_CS_SMPTE_170}, 0, 0, VE, "colorspace" },
>> +    { "smpte240",        NULL, 0, AV_OPT_TYPE_CONST, {.i64 = VPX_CS_SMPTE_240}, 0, 0, VE, "colorspace" },
>> +    { "bt2020",          NULL, 0, AV_OPT_TYPE_CONST, {.i64 = VPX_CS_BT_2020},   0, 0, VE, "colorspace" },
>> +    { "reserved",        NULL, 0, AV_OPT_TYPE_CONST, {.i64 = VPX_CS_RESERVED},  0, 0, VE, "colorspace" },
>> +    { "sRGB",            NULL, 0, AV_OPT_TYPE_CONST, {.i64 = VPX_CS_SRGB},      0, 0, VE, "colorspace" },
>> +#endif
>
> why does this not use AVCodecContext.colorspace or other colorspace
> related fields ?
>

no good reason, I forgot to compare them.