[FFmpeg-devel] [PATCH] postproc: fix unaligned access

[Michael Niedermayer]

On Thu, Jun 18, 2015 at 08:29:06PM +0200, Andreas Cadhalpun wrote:
> QP_store is only 8-bit-aligned, so accessing it as uint32_t causes
> SIGILL crashes on sparc.
> 
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> ---
>  libpostproc/postprocess.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/libpostproc/postprocess.c b/libpostproc/postprocess.c
> index 92cc436..e4ea515 100644
> --- a/libpostproc/postprocess.c
> +++ b/libpostproc/postprocess.c
> @@ -996,10 +996,7 @@ void  pp_postprocess(const uint8_t * src[3], const int srcStride[3],
>          if (QPStride >= 0){
>              int i;
>              const int count= FFMAX(mbHeight * QPStride, mbWidth);
> -            for(i=0; i<(count>>2); i++){
> -                ((uint32_t*)c->nonBQPTable)[i] = ((const uint32_t*)QP_store)[i] & 0x3F3F3F3F;
> -            }
> -            for(i<<=2; i<count; i++){

maybe this can be left under #if HAVE_FAST_UNALIGNED with
AV_RN32 AV_WN32


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150618/d00308a6/attachment.asc>