[FFmpeg-devel] [PATCH] vda: unlock the pixel buffer base address.

[Clément Bœsch]

On Mon, Jun 22, 2015 at 03:31:43PM +0200, Clément Bœsch wrote:
> On Sat, Jun 20, 2015 at 05:12:47PM +0200, Clément Bœsch wrote:
> > On Sat, Jun 20, 2015 at 04:25:55PM +0200, Michael Niedermayer wrote:
> > > On Sat, Jun 20, 2015 at 01:19:29PM +0200, Sebastien Zwickert wrote:
> > > > The pixel buffer base address is never unlocked this causes
> > > > a bug with some pixel format types that are produced natively
> > > > by the hardware decoder: the first buffer was always used.
> > > > Unlock the pixel buffer base address fixes the issue.
> > > > 
> > > > ---
> > > >  ffmpeg_vda.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > 
> > > LGTM
> > > 
> > > thanks
> > > 
> > 
> > FYI this is supposed to fix normal cases like:
> > 
> > wget http://lucy.pkh.me/samples/natsuno.mp4
> > ffmpeg -hwaccel vda -i natsuno.mp4 -t 15 out.avi
> > 
> > For some reason it's working if requesting
> > kCVPixelFormatType_420YpCbCr8Planar (yuv420p) but not
> > kCVPixelFormatType_422YpCbCr8: (uyvy422, default with ff) or
> > kCVPixelFormatType_32BGRA (rgb32)
> > 
> > I can't confirm it fixes the issue because I haven't the hw to test right
> > now, but I believe it does :)
> > 
> 
> Patch tested. LGTM. Thanks.
> 

Side note: should be backported

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150622/8187a0d5/attachment.asc>