[FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

[Clément Bœsch]

On Tue, Jun 23, 2015 at 07:36:54AM -0700, Philip Langdale wrote:
> On Tue, 23 Jun 2015 11:14:36 +0530
> Niklesh Lalwani <niklesh.lalwani at iitb.ac.in> wrote:
> 
> > On 6/23/15, Philip Langdale <philipl at overt.org> wrote:
> > > I got a bunch of warnings when I compiled it. Please fix.
> > >
> > > Thanks.
> > >
> > > ----------------------------------------------------------
> > >
> > > CC libavcodec/movtextenc.o
> > > libavcodec/movtextenc.c: In function ‘mov_text_style_cb’:
> > > libavcodec/movtextenc.c:124:17: warning: ‘return’ with a value, in
> > > function returning void return AVERROR(ENOMEM);
> > > ^
> > > libavcodec/movtextenc.c:138:21: warning: ‘return’ with a value, in
> > > function returning void return AVERROR(ENOMEM);
> > > ^
> > > libavcodec/movtextenc.c:167:13: warning: ‘return’ with a value, in
> > > function returning void return AVERROR(ENOMEM);
> > 
> > The function mov_text_style_cb() is a void function, I'll make it int
> > funciton to return a value.
> 
> The function signature is fixed by the ASS callback struct - you can't
> change it. That means that it has to stay void.

Fortunately, ASSCodesCallbacks is not public API, so this can be changed
in a first commit (or postponed and adjusted after this is applied).

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150624/2506f435/attachment.asc>