[FFmpeg-devel] [RFC] [WIP] [PATCH] lavfi: add drawgraph filter

[Michael Niedermayer]

On Wed, Jun 24, 2015 at 05:49:35PM +0000, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
> Example:
> 
> ffplay movie.webm -vf signalstats,drawgraph=lavfi.signalstats.YAVG:min=0:max=255:mode=0
> 
> ---
>  libavfilter/Makefile       |   1 +
>  libavfilter/allfilters.c   |   1 +
>  libavfilter/vf_drawgraph.c | 186 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 188 insertions(+)
>  create mode 100644 libavfilter/vf_drawgraph.c

nice, i like this filter!


[...]
> +    metadata = av_frame_get_metadata(in);
> +    e = av_dict_get(metadata, s->key, NULL, 0);

this could be extended to also support AVOptions
aka av_get_double(in, s->key...)

LGTM otherwise

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150625/56b4a1b0/attachment.asc>