[FFmpeg-devel] [PATCH] avutil/dict: Print warning in case av_dict_set() fails to allocate memory

[wm4]

On Sun, 28 Jun 2015 17:47:51 +0200
Nicolas George <george at nsup.org> wrote:

> Le decadi 10 messidor, an CCXXIII, Michael Niedermayer a écrit :
> > This avoids the need to print such warning in all callers
> 
> I believe this is a bad idea: the warning will be duplicated when callers
> already include them.
> 
> There are low-level APIs that return an error and high-level APIs that print
> error messages. Changing the status of an API is not a good idea. Creating a
> new API is the way to go.

+1

Another argument: once the terrible global log callback is removed,
av_dict_set must either include a new argument that gives it access
to a log callback, or it must drop the message anyway.