[FFmpeg-devel] Patch to parse H264 SEI Green Metadata

[Nicolas Derouineau]

Please find here enclosed the patch synthesizing all your comments.

Nicolas DEROUINEAU
Research Engineer
VITEC

T.  +33 1 46 73 06 06
E.  nicolas.derouineau at vitec.com
W. www.vitec.com

________________________________________
De : ffmpeg-devel-bounces at ffmpeg.org <ffmpeg-devel-bounces at ffmpeg.org> de la part de Carl Eugen Hoyos <cehoyos at ag.or.at>
Envoyé : mardi 30 juin 2015 12:47
À : FFmpeg development discussions and patches
Objet : Re: [FFmpeg-devel] Patch to parse H264 SEI Green Metadata

On Tuesday 30 June 2015 12:30:50 pm Nicolas Derouineau wrote:
> >> @@ -2610,6 +2610,7 @@ typedef struct AVCodecContext {
> >>  #define FF_DEBUG_ER          0x00000400
> >>  #define FF_DEBUG_MMCO        0x00000800
> >>  #define FF_DEBUG_BUGS        0x00001000
> >> +#define FF_DEBUG_GREEN_MD    0x00001200
> >
> >I believe this has to come at the end of the list with value 0x20000.
>
> Michael Niedermayer has sugested 0x00800000. I'm however going to use the
> one you suggest (as it is the last comment). Corrected.

Please use what Michael suggested, sorry that I had missed it.

> >Your av_logs could use a linebreak after the string.
>
> I'm not sure I understand correctly this last comment. I have unified the
> number of space in the strings.

av_log(context, "a string with %d %d %d \n", some variables);
vs.
av_log(context, "string",
       variables);

(This of course only makes sense for long lines!)

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Enabling-Greenmetadata-SEI-parsing.patch
Type: text/x-patch
Size: 7461 bytes
Desc: 0001-Enabling-Greenmetadata-SEI-parsing.patch
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150630/75c0cfc0/attachment.bin>