[FFmpeg-devel] [PATCH 2/3] avformat: map T.140 RTP codec to text

Clément Bœsch u at pkh.me
Sun Mar 1 08:25:12 CET 2015


On Sat, Feb 28, 2015 at 11:15:40PM +0100, Gilles Chanteperdrix wrote:
> This makes more sense than mapping to AV_CODEC_ID_SUBRIP. Nothing
> indicates that a T.140 track contains subrip sub-titles.
> 
> Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix at xenomai.org>
> ---
>  libavformat/rtpdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c
> index 8cd2f26..2227e23 100644
> --- a/libavformat/rtpdec.c
> +++ b/libavformat/rtpdec.c
> @@ -59,7 +59,7 @@ static RTPDynamicProtocolHandler opus_dynamic_handler = {
>  static RTPDynamicProtocolHandler t140_dynamic_handler = { /* RFC 4103 */
>      .enc_name   = "t140",
>      .codec_type = AVMEDIA_TYPE_SUBTITLE,
> -    .codec_id   = AV_CODEC_ID_SUBRIP,
> +    .codec_id   = AV_CODEC_ID_TEXT,
>  };
>  

What do the subs look like? Is it really just plaintext or there is some
binary or whatever markup?

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150301/b656b42c/attachment.asc>


More information about the ffmpeg-devel mailing list