[FFmpeg-devel] [libav-devel] [PATCH] avformat/rmenc: limit packet size

[Michael Niedermayer]

On Mon, Mar 02, 2015 at 04:56:34PM +0100, Andreas Cadhalpun wrote:
> On 02.03.2015 16:21, Luca Barbato wrote:
> >On 02/03/15 16:06, Andreas Cadhalpun wrote:
> >>Yes, the rm format can contain larger frames split into slices and
> >>packed in multiple packets. But currently the rv10/rv20 encoders always
> >>produce a whole frame and the rm muxer always produces one packet per
> >>frame.
> >
> >Then there is the missing_feature logger call and AVERROR(ENOSYS).
> 
> OK.
> 
> >You could make the constant self-explanatory by doing something like
> >
> >#define MAX_HEADER_SIZE (7 + 4 + 12)
> >#define MAX_PACKET_SIZE (UINT16_MAX - MAX_HEADER_SIZE)
> 
> Fine with me. New patch attached.
> 
> Best regards,
> Andreas
> 

>  rmenc.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 756720c53cc59fb2206fc7520043b905058a3032  0001-avformat-rm-limit-packet-size.patch
> From 17536f5ca03a6fdda8486495bfd3bfd4f5258e70 Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Mon, 2 Mar 2015 16:52:26 +0100
> Subject: [PATCH] avformat/rm: limit packet size
> 
> The chunk size is limited to UINT16_MAX (written by avio_wb16), so make
> sure that the packet size is not too large.
> 
> Such large frames need to be split into slices smaller than 64 kB, but
> that is currently supported neither by the rv10/rv20 encoders nor the rm
> muxer.

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150302/f04d2c7f/attachment.asc>