[FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

[Nicolas George]

Le septidi 17 ventôse, an CCXXIII, Gilles Chanteperdrix a écrit :
> You need an ASS file that produces a sub-title frame without text. I
> have been carrying this patch since 2013, I am afraid I no longer
> have the problematic file.

I tried an ASS file with an empty text part, and it did not crash either. It
is entirely possible the problem has disappeared due to some of the reworks
of the text subtitles code since you experienced it.

I am sorry to insist, but I am always suspicious of changes that go "if the
value is not what we expect, silently ignore it", because they frequently
should return an error or hide a bug earlier in the code; for these reasons,
I would like either a more detailed analysis or a chance to see for myself
before this patch is applied.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150307/a2ef5dcf/attachment.asc>