[FFmpeg-devel] [PATCH] hevc: fix deadlock for frame threading safe callbacks disabled

[Rainer Hochecker]

Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:


> 
> I sent an alternative patch "pthread: Fix ff_thread_get_format issues
> when called outside frame decode."

right, I didn't see you patch not the other code path.

> However there are additional bugs like update_context calling this and thus
> a single SPS change with n threads resulting in n get_format callbacks,
> all except the first completely pointless (and potentially causing
> issues with implementations that don't ensure that multiple get_format
> are side-effect free).
> As a result I am somewhat hesitant about my patch that would end up
> hiding all these issues.
> 

the issue with multiple get_format calls is already present for other codecs.