[FFmpeg-devel] [PATCH 1/8] ffmdec: initialize f_cprv, f_stvi and f_stau

[Lukasz Marek]

On 09.03.2015 02:45, Michael Niedermayer wrote:
> On Mon, Mar 09, 2015 at 12:02:55AM +0100, Andreas Cadhalpun wrote:
>> Hi,
>>
>> attached patch fixes 'Conditional jump or move depends on
>> uninitialized variables' valgrind warnings.
>>
>> Best regards,
>> Andreas
>
>>   ffmdec.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 4a297cdd7cdb822a449cd846139a86ae284893aa  0001-ffmdec-initialize-f_cprv-f_stvi-and-f_stau.patch
>>  From 8b1088fa1509b1613d095fbe1c11eec6d251c95c Mon Sep 17 00:00:00 2001
>> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> Date: Sun, 8 Mar 2015 22:52:47 +0100
>> Subject: [PATCH 1/8] ffmdec: initialize f_cprv, f_stvi and f_stau
>>
>> They are used in a switch statement, but it is not guaranteed that the
>> COMM case (where they are set to 0) is reached before the other cases.
>
> applied
>
> thanks

In fact this is a bit wrong. COMM is guaranteed unless malformed file is 
parsed. These variables are dedicated to detect doubled sections. This 
patch allows them to occur twice in that case. So they should be 
initialized to 0.