[FFmpeg-devel] [PATCH] is_compiled flag not being cleared in av_opencl_uninit

[Srikanth G]

Hi Michael,

I did the fix and verified compilation and run.
Confirmed it works.

Here is the patch


---
 libavutil/opencl.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavutil/opencl.c b/libavutil/opencl.c
index 36cb6fe..2df5653 100644
--- a/libavutil/opencl.c
+++ b/libavutil/opencl.c
@@ -588,6 +588,7 @@ end:

 void av_opencl_uninit(void)
 {
+    int i;
     cl_int status;
     LOCK_OPENCL;
     opencl_ctx.init_count--;
@@ -611,6 +612,9 @@ void av_opencl_uninit(void)
         }
         opencl_ctx.context = NULL;
     }
+    for (i = 0; i < opencl_ctx.kernel_code_count; i++) {
+        opencl_ctx.kernel_code[i].is_compiled = 0;
+    }
     free_device_list(&opencl_ctx.device_list);
 end:
     if (opencl_ctx.init_count <= 0)
-- 
1.9.0.msysgit.0


Thanks,
Srikanth

On Sat, Mar 7, 2015 at 12:14 PM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> On Sat, Mar 07, 2015 at 10:53:05AM -0600, Srikanth G wrote:
> > Hi Michael,
> >
> > Can you let me know the compilation errors?
> > I tried with this fix and things were working for me.
> >
> > I will try again though.
>
> you can checkout a fresh ffmpeg and apply the patch
> "i" is not declared in that function so it will not build
> the fix is trivial but i expect code to be tested, which this
> obviously has not been and would not magically be if i add int i
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker.
> User
> questions about the command line tools should be sent to the ffmpeg-user
> ML.
> And questions about how to use libav* should be sent to the libav-user ML.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>