[FFmpeg-devel] [PATCH] lavfi/eq: factorize code in process_command through a macro

[Stefano Sabatini]

On date Friday 2015-03-13 20:05:35 +0100, Michael Niedermayer encoded:
> On Fri, Mar 13, 2015 at 05:16:53PM +0100, Stefano Sabatini wrote:
> > ---
> >  libavfilter/vf_eq.c | 56 ++++++++++++++---------------------------------------
> >  1 file changed, 15 insertions(+), 41 deletions(-)
> 
> i would be more in favor of a function than a macro but LGTM either
> way, macros are harder to debug and all kind of line number based
> outputs are basically useless with multiline macros, be that
> static analyzers of dynamic ...
> 
> 
> 
> set_param(cmd, "gamma_g", &eq->gamma_g_pexp, args, ctx, eq, &ret);
> set_param(cmd, "gamma_r", &eq->gamma_r_pexp, args, ctx, eq, &ret);
> if (ret < 0)

Up.
-- 
FFmpeg = Fantastic Fundamental Miracolous Patchable Elitarian Gargoyle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-eq-factorize-code-in-process_command.patch
Type: text/x-diff
Size: 3041 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150315/d680db97/attachment.bin>