[FFmpeg-devel] [PATCH] avfilter/showwaves: add single_pic option

Stefano Sabatini stefasab at gmail.com
Mon Mar 16 16:11:24 CET 2015


On date Sunday 2014-12-28 12:48:19 +0100, Clément Bœsch encoded:
> On Fri, Dec 26, 2014 at 01:16:07AM +0100, Stefano Sabatini wrote:
> > On date Friday 2014-12-26 00:17:53 +0100, Clément Bœsch encoded:
[...]
> The first case has its use cases. Random example:
> https://soundcloud.com/explore
> 
> > 
> > The two approaches are not mutually exclusive, but the latter is
> > probably more flexible.
> > 
> 
> In the second case, you'll probably need successive scaling before you
> reach the targeted size. It's probably a bit more complex than the current
> patch, but might do the trick.
> 
> Note that, while I don't think it will matter, the beginning of the track
> will probably suffer from accuracy given how many time it will be
> averaged/scaled.
> 

> > I'll prepare a patch to cover case 2. About case 1, I wonder if having
> > a dedicated filter (sharing part of the code of showwaves) wouldn't be
> > a better approach, but I'm not sure it will.
> 
> I'm a bit lazy to do that, feel free to take over this patch.

What do you think of a separate filter to cover single_pic? See
attached patch.
-- 
FFmpeg = Fiendish and Frenzy Monstrous Puritan Extravagant Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-add-showwavespic-filter.patch
Type: text/x-diff
Size: 15227 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150316/0c18250b/attachment.bin>


More information about the ffmpeg-devel mailing list