[FFmpeg-devel] [PATCH 1/4] libavdevice/avfoundation: add framerate and video size options

[Matthieu Bouron]

On Sat, Mar 14, 2015 at 11:09 AM, Matthieu Bouron <matthieu.bouron at gmail.com
> wrote:

> On Sat, Mar 14, 2015 at 11:01 AM, Matthieu Bouron <
> matthieu.bouron at gmail.com> wrote:
>
>>
>>
>> On Sat, Mar 14, 2015 at 8:31 AM, Carl Eugen Hoyos <cehoyos at ag.or.at>
>> wrote:
>>
>>>  <matthieu.bouron <at> gmail.com> writes:
>>>
>>> > +    for (NSObject *format in
>>>
>>> You may ignore this but I just changed the code
>>> to not mix declarations and statements to
>>> silence warnings when compiling with old gcc
>>> compilers...
>>>
>>
>> I don't have access to an older version of OSX which uses gcc.
>> I've updated the patch locally to separate declarations and statements.
>>
>>
>>>
>>> > +                if (framerate == 0.0
>>>
>>> Just asking: Does this really work?
>>>
>>
>> Nope it doesn't, it's just a glitch i forget to remove when i was not
>> using the AV_OPT_TYPE_IMAGE_SIZE for the framerate option (and the value
>> was defaulting to 0).
>> I've removed it locally.
>>
>
> New patch attached.
>
>
ping