[FFmpeg-devel] [PATCH] replace cookies with updated values

Michael Niedermayer michaelni at gmx.at
Wed Mar 18 20:05:07 CET 2015


On Tue, Mar 17, 2015 at 08:55:11PM +1100, Micah Galizia wrote:
> Hi,
> 
> The current Set-Cookie handling appends cookies to the string without
> checking to see if a cookie with the same name should have its value
> updated.
> 
> This is my second attempt to fix this issue -- last time it was a bit
> of a string parsing nightmare. This time its a little less complex
> (using a dictionary).
> 
> Before we start the "the existing implementation sucks, change it"
> discussion I've looked into passing them around in their dictionary
> form (an only using the string to initialize cookies from an external
> source) but so far as I can tell, AVDictonary cannot be retrieved
> using av_opt_get or av_opt_find right now.
> 
> Anyway, I hope this is sufficient for inclusion.
> 
> TIA
> -- 
> "The mark of an immature man is that he wants to die nobly for a
> cause, while the mark of the mature man is that he wants to live
> humbly for one."   --W. Stekel

>  http.c |   65 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 52 insertions(+), 13 deletions(-)
> 186645452fc5d5febd374b5ab91a1d9215ece986  0003-replace-cookies-with-updated-values-instead-of-appen.patch
> From 18b00063d177965facd805d6b89eb96af371de94 Mon Sep 17 00:00:00 2001
> From: Micah Galizia <micahgalizia at gmail.com>
> Date: Tue, 17 Mar 2015 20:22:59 +1100
> Subject: [PATCH 3/3] replace cookies with updated values instead of appending
>  forever

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150318/573d17dd/attachment.asc>


More information about the ffmpeg-devel mailing list