[FFmpeg-devel] OpenExr Compression technique added -GSoc 15

[Michael Niedermayer]

On Sun, Mar 22, 2015 at 01:12:57AM +0530, greeshma wrote:
> New compression technique -B44 lossy compression for OpenExr
> 
> From d6da9dea16a5b8247aac60a0ce21cb56981e66ec Mon Sep 17 00:00:00 2001
> From: greeshmab <greeshmabalabadra at gmail.com>
> Date: Sun, 22 Mar 2015 01:09:53 +0530
> Subject: [PATCH] new compression
> 
[...]
>  exr.c |  122 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 122 insertions(+)
> 3a408b9625437f474632f0f9247f3bf5a86e6323  0001-new-compression.patch
> From d6da9dea16a5b8247aac60a0ce21cb56981e66ec Mon Sep 17 00:00:00 2001
> From: greeshmab <greeshmabalabadra at gmail.com>
> Date: Sun, 22 Mar 2015 01:09:53 +0530

> Subject: [PATCH] new compression

the commit message is too unclear/unspecific. it should explain what
is added and why
also it should mention where code is from if its based on some
previously existing code


> 
> ---
>  libavcodec/exr.c | 122 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 122 insertions(+)

this breaks
make fate-exr

TEST    exr-slice-raw
TEST    exr-slice-rle
TEST    exr-slice-zip1
TEST    exr-slice-zip16
TEST    exr-slice-pxr24
--- ./tests/ref/fate/exr-slice-rle      2015-03-21 12:36:23.469794458 +0100
+++ tests/data/fate/exr-slice-rle       2015-03-22 00:17:20.670680485 +0100
@@ -1,2 +1,2 @@
 #tb 0: 1/25
-0,          0,          0,        1,  3169800, 0x6a356d0d
+0,          0,          0,        1,  3169800, 0x00000000
Test exr-slice-rle failed. Look at tests/data/fate/exr-slice-rle.err for details.
make: *** [fate-exr-slice-rle] Error 1
make: *** Waiting for unfinished jobs....

you will need the fate samples to run the fate tests see
https://ffmpeg.org/fate.html#Using-FATE-from-your-FFmpeg-source-directory


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150322/60c8f256/attachment.asc>