[FFmpeg-devel] [PATCH] avformat/utils: Terminate SPS in avci100_1080i_extradata to avoid warnings during parsing

[Reimar Döffinger]

On 23.03.2015, at 22:05, Michael Niedermayer <michaelni at gmx.at> wrote:
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
> libavformat/utils.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index 6a0f666..6eec7a1 100644
> --- a/libavformat/utils.c
> +++ b/libavformat/utils.c
> @@ -4345,7 +4345,7 @@ int ff_generate_avci_extradata(AVStream *st)
>         0x11, 0x12, 0x08, 0xc6, 0x8c, 0x04, 0x41, 0x28,
>         0x4c, 0x34, 0xf0, 0x1e, 0x01, 0x13, 0xf2, 0xe0,
>         0x3c, 0x60, 0x20, 0x20, 0x28, 0x00, 0x00, 0x03,
> -        0x00, 0x08, 0x00, 0x00, 0x03, 0x01, 0x94, 0x00,
> +        0x00, 0x08, 0x00, 0x00, 0x03, 0x01, 0x94, 0x20,

Well, going by your description it makes a lot of sense, but I thought someone
copy-pasted this from some reference files/specification/conversion program?
It might be that the source for these was a bit buggy though, I think we saw that in some other case for AVCI.
If nobody has a good answer I'd say apply it. My biggest concern is that some programs may no longer recognize the stream as AVCI compatible after conversion with this change, but probably it's not an issue in reality.