[FFmpeg-devel] [PATCH] avformat/utils: Terminate SPS in avci100_1080i_extradata to avoid warnings during parsing

[Michael Niedermayer]

On Tue, Mar 24, 2015 at 07:53:22AM +0000, Carl Eugen Hoyos wrote:
> Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> 
> > > -        0x00, 0x08, 0x00, 0x00, 0x03, 0x01, 0x94, 0x00,
> > > +        0x00, 0x08, 0x00, 0x00, 0x03, 0x01, 0x94, 0x20,
> > 
> > Well, going by your description it makes a lot of sense, 
> > but I thought someone copy-pasted this from some 
> > reference files/specification/conversion program?

it could be that the reference was from a lower layer, but at the
layer at which extradata is the RBSP terminantion is needed, also
its either way needed between SPS and PPS so the reference would
have had to contain 2 seperate arrays not one as we have and
whoever combined the 2 then made a mistake

also whats worse is that i think that with streamcopy you can write
this invalid SPS/PPS into a file


> 
> The copy-pasted extradata contained another error 
> (the aspect ratio was wrong).

applied

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150324/e94a1b07/attachment.asc>