[FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: add support for muxing mxf opatom audio

[Tomas Härdin]

On Wed, 2015-03-25 at 15:43 -0700, Mark Reid wrote:
> On Mar 24, 2015 7:05 AM, "Tomas Härdin" <tomas.hardin at codemill.se> wrote:
> >
> > On Sat, 2015-03-21 at 16:45 -0700, Mark Reid wrote:
> > > ---
> > >  libavformat/mxfenc.c | 100
> ++++++++++++++++++++++++++++++++++++++++++---------
> > >  1 file changed, 83 insertions(+), 17 deletions(-)
> >
> > Looks fine as far as I can tell. My only nitpick is that it might be
> > better to call "timecode rate" EditRate or "edit rate" instead, since
> > that is MXF parlance. Perhaps a bit bikeshed-y though. Does anyone else
> > have any preference?
> >
> 
> I was going to originally go with audio_edit_rate, I think its in line with
> the mxf terminology too. So I'll submit a new patch changing it.

Ah, alright

> > An aside: would it ever make sense to use EditRate different from fps,
> > to force a certain rate? Something tells me there's a video filter or
> > something to do that already, so perhaps not an issue.
> >
> > /Tomas
> >
> 
> It might, but I'm not sure, I think avid mxf might use 30fps timecode on
> 24fps footage if using pulldown or vice versa. I'll take a look. In which
> case, even this audio case, maybe the edit_rate of the timecode should be
> export as metadata so a decoding application could know what it is?

I think we can save that for when we know it's needed by some
application.

/Tomas