[FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

[Pascal Massimino]

Michael,

On Fri, Mar 27, 2015 at 1:37 PM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> On Fri, Mar 27, 2015 at 11:02:09AM +0100, Pascal Massimino wrote:
> > Hi,
> >
> > $subject
> >
> > $attached says:
> > ------------------------------------------------------------------------
> > This API is available at head (MUX_ABI_VERSION >= 0x0104), is stable,
> >  and will be made official in future release.
> > For compatibility, the previous code is left as fallback.
> >
> > Dont' forget to use --enable-libwebp as ./configure option.
> >
> > This new code handles video, so that something like
> >    ffmpeg -i video.mp4 -y anim.webp
> > should just work.
> >
> > -loop option is also supported.
> > ------------------------------------------------------------------------
> >
> > Comments welcome!
> > skal/
>
> breaks build if libwebp* is unavailable
> make
> CC      libavformat/webpenc.o
> /home/michael/ffmpeg-git/ffmpeg/libavformat/webpenc.c:27:25: fatal error:
> webp/encode.h: No such file or directory
>

oh indeed. What would you recommend as #ifdef protection? Do we need a new
#define?


>
> >  configure               |    4
> >  libavcodec/libwebpenc.c |  399
> ++++++++++++++++++++++++++++--------------------
> >  libavformat/webpenc.c   |   41 ++++
> >  3 files changed, 281 insertions(+), 163 deletions(-)
> > 20e2236a5a357c8509446cf3bf79ce22457132e5
> 0001-use-WebPAnimEncoder-API-to-generate-animated.patch
> > From dcad4a82df4d0e63f187e51c858038ea4508e4b6 Mon Sep 17 00:00:00 2001
> > From: Urvang Joshi <urvang at google.com>
> > Date: Fri, 27 Mar 2015 10:42:57 +0100
> > Subject: [PATCH] use WebPAnimEncoder API to generate animated WebP
> >
> > This API is available at head (MUX_ABI_VERSION >= 0x0104), is stable,
> >  and will be made official in future release.
> > For compatibility, the previous code is left as fallback.
> >
> > Dont' forget to use --enable-libwebp as ./configure option.
> >
>
> > This new code handles video, so that something like
> >    ffmpeg -i video.mp4 -y anim.webp
> > should just work.
>
> doesnt that already work before the patch ?
>

indeed, the remark is misleading. I meant: it just work like before
(but it's just that using WebPAnimEncoder alternative offers more
flexibility -now or in the future-).



>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> No human being will ever know the Truth, for even if they happen to say it
> by chance, they would not even known they had done so. -- Xenophanes
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>