[FFmpeg-devel] [PATCH 2/4] FFV1 specification: Add missing { }

[Michael Niedermayer]

On Sat, May 02, 2015 at 12:37:19AM +0200, Jerome Martinez wrote:
> Le 02/05/2015 00:21, Michael Niedermayer a écrit :
> >why the extra space ?
> 
> Because of a guy doing stupid mistakes.
> (this guy may try to blame Lyx but it is difficult to be believable)
> 
> New patch attached.

>  ffv1.lyx |   39 +++++++++++++++++++++++++++++++++++++--
>  1 file changed, 37 insertions(+), 2 deletions(-)
> e1cfed37778ede58a4d592af760a778004ff76d5  0002-Add-missing.patch
> From 40a211a344c3f7bcb8bc627bd5edcb4cb8b1c56c Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jerome at mediaarea.net>
> Date: Fri, 1 May 2015 14:22:06 +0200
> Subject: [PATCH 2/4] Add missing { }
> 
> ---
>  ffv1.lyx | 39 +++++++++++++++++++++++++++++++++++++--
>  1 file changed, 37 insertions(+), 2 deletions(-)
> 
> diff --git a/ffv1.lyx b/ffv1.lyx
> index c30ad67..6608ccf 100644
> --- a/ffv1.lyx
> +++ b/ffv1.lyx
> @@ -3972,7 +3972,7 @@ Slice Header
>  
>  \begin_layout Standard
>  \begin_inset Tabular
> -<lyxtabular version="3" rows="14" columns="2">
> +<lyxtabular version="3" rows="15" columns="2">
>  <features rotate="0" tabularvalignment="middle">
>  <column alignment="left" valignment="top">
>  <column alignment="center" valignment="top">
> @@ -4347,7 +4347,7 @@ ur
>  \begin_inset space ~
>  \end_inset
>  
> -if( version > 3 )
> +if( version > 3 ) {
>  \end_layout
>  
>  \end_inset
> @@ -4465,6 +4465,41 @@ ur
>  </cell>
>  </row>
>  <row>
> +<cell alignment="center" valignment="top" topline="true" leftline="true" usebox="none">
> +\begin_inset Text
> +
> +\begin_layout Plain Layout
> +\begin_inset space ~
> +\end_inset
> +
> +
> +\begin_inset space ~
> +\end_inset
> +
> +
> +\begin_inset space ~
> +\end_inset
> +
> +
> +\begin_inset space ~
> +\end_inset
> +
> +}
> +\end_layout
> +
> +\end_inset
> +</cell>
> +<cell alignment="center" valignment="top" topline="true" leftline="true" rightline="true" usebox="none">
> +\begin_inset Text
> +
> +\begin_layout Plain Layout
> +
> +\end_layout
> +
> +\end_inset
> +</cell>
> +</row>
> +<row>

this looks wrong in my lyx, quite wrong, certainly doesnt result
in a closing bracket
note, that is when i apply the patch, as you didnt push it to your
tree


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150502/bad1bb38/attachment.asc>