[FFmpeg-devel] [PATCH] avfilter: add findandcover filter

[Michael Niedermayer]

On Thu, Apr 30, 2015 at 01:11:41PM -0800, Lou Logan wrote:
> On Thu, 30 Apr 2015 14:11:20 +0200, Michael Niedermayer wrote:
> 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  configure                     |    1 +
> >  doc/filters.texi              |   46 +++++
> >  libavfilter/Makefile          |    1 +
> >  libavfilter/allfilters.c      |    1 +
> >  libavfilter/version.h         |    2 +-
> >  libavfilter/vf_findandcover.c |  399 +++++++++++++++++++++++++++++++++++++++++
> >  6 files changed, 449 insertions(+), 1 deletion(-)
> >  create mode 100644 libavfilter/vf_findandcover.c
> > 
> [...]
> > + at item xmin, ymin, xmax, ymax
> > +Specifies the recatangle in which to search.
> 
> typo: recatangle/rectangle
> 
> 
> [...]
> > +    { "ymax", "", OFFSET(ymax), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, FLAGS },
> > +    { "mode", "set removial mode", OFFSET(mode), AV_OPT_TYPE_INT, {.i64 = MODE_BLUR}, 0, NB_MODES - 1, FLAGS, "mode" },
> 
> typo: removial/removal
> 
> This concludes my amazingly useful review.

both locally fixed

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150502/8cd99b19/attachment.asc>