[FFmpeg-devel] [PATCH 1/2] id3v2: do not export APIC description if empty
wm4
nfxjfg at googlemail.com
Thu May 7 23:56:36 CEST 2015
APIC tags always have a description. Tag writers obviously leave it
empty if there is no description. In this case, libavformat would export
"" as title. Do not set the title instead.
---
Somewhat questionable. Take it or leave it.
---
libavformat/id3v2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
index a8273e2..1c57dd9 100644
--- a/libavformat/id3v2.c
+++ b/libavformat/id3v2.c
@@ -1082,7 +1082,8 @@ int ff_id3v2_parse_apic(AVFormatContext *s, ID3v2ExtraMeta **extra_meta)
st->disposition |= AV_DISPOSITION_ATTACHED_PIC;
st->codec->codec_type = AVMEDIA_TYPE_VIDEO;
st->codec->codec_id = apic->id;
- av_dict_set(&st->metadata, "title", apic->description, 0);
+ if (apic->description[0])
+ av_dict_set(&st->metadata, "title", apic->description, 0);
av_dict_set(&st->metadata, "comment", apic->type, 0);
av_init_packet(&st->attached_pic);
--
2.1.4
More information about the ffmpeg-devel
mailing list