[FFmpeg-devel] [PATCH] FFV1 specification: Merge of FrameHeader01() and GlobalHeader()

[Michael Niedermayer]

On Mon, May 18, 2015 at 09:04:01PM +0200, Jerome Martinez wrote:
> 

>  ffv1.lyx |  530 ++++++++++++++++++++++++---------------------------------------
>  1 file changed, 204 insertions(+), 326 deletions(-)
> 38da62e7514e7ece306076f4de29aa1f99279920  0001-Merge-of-FrameHeader01-and-GlobalHeader.patch
> From c6f16e561d40972e058f4e163ff753bce8fc8acc Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jerome at mediaarea.net>
> Date: Mon, 18 May 2015 20:59:09 +0200
> Subject: [PATCH] Merge of FrameHeader01() and GlobalHeader()
> 
> FrameHeader01() and GlobalHeader() have a lot of common fields
> and having a common function + default value for fields unused
> in previous versions is less complex and more coherent than repeating
> the common part.

maybe but calling the GlobalHeader FrameHeader is very confusing
and wrong


[...]

> @@ -7939,6 +7809,10 @@ pred = j ? initial_states[ i ][j - 1][ k ] : 128
>  
>  initial_state[ i ][ j ][ k ] = ( pred + initial_state_delta[ i ][ j ][ k
>   ] ) & 255
> +\begin_inset Newline newline
> +\end_inset
> +
> +Inferred to be 0 if not present.

what is inferred to be 0? initial_state? initial_state_delta?
i think this could be misunderstood as the paragraph is talking
about multiple variables

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150519/bd5bcd43/attachment.asc>