[FFmpeg-devel] [PATCH]lavf/nmov: Write colour matrix "6" for color_space bt470bg

[Ronald S. Bultje]

Hi,

On Wed, May 20, 2015 at 12:32 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Our mov demuxer claims that "6" is bt470bg, so write "6" if
> the user specified bt470bg.
>
[..]

>      }
>      switch (track->enc->colorspace) {
>      case AVCOL_TRC_BT709:     avio_wb16(pb, 1); break;
> +    case AVCOL_PRI_BT470BG:
>      case AVCOL_PRI_SMPTE170M: avio_wb16(pb, 6); break;
>      case AVCOL_PRI_SMPTE240M: avio_wb16(pb, 7); break;
>      default:                  avio_wb16(pb, 2);
>
> Am I the only one that thinks it's weird that we read the SPC field as a
combination/mixture of TRC/PRI instead of SPC fields?

(I know the enum values are identical between TRC/SPC/PRI, so this is amore
a stylistic comment than anything else.)

Ronald