[FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

[Michael Niedermayer]

On Mon, May 25, 2015 at 11:22:32PM +0200, Andreas Cadhalpun wrote:
> On 25.05.2015 21:38, Michael Niedermayer wrote:
> > On Mon, May 25, 2015 at 05:25:18PM +0200, Andreas Cadhalpun wrote:
> > [...]
> > 
> >>  mov.c |    7 +++++++
> >>  1 file changed, 7 insertions(+)
> >> 7ff306f094f2ecd47b720deb20ea318c24efaf4d  0002-mov-reject-zero-bytes_per_frame-with-non-zero-sample.patch
> >> From 42c8b0c216b39fd2cb8b329669737ce771ecdd20 Mon Sep 17 00:00:00 2001
> >> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> >> Date: Mon, 25 May 2015 17:17:39 +0200
> >> Subject: [PATCH 2/2] mov: reject zero bytes_per_frame with non-zero
> >>  samples_per_frame
> >>
> >> In this case the mov demuxer can return a large number of empty packets.
> > 
> > patch should be ok, maybe add avpriv_request_sample()
> 
> OK, attached is variant with av_log replaced with avpriv_request_sample.
> 
> Best regards,
> Andreas
> 

>  mov.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> c185b2df006a58a43895518f090520799aaa6965  0001-mov-reject-zero-bytes_per_frame-with-non-zero-sample.patch
> From 9897fdaf2a714656dbadba6c9f7a813c39aa568e Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Mon, 25 May 2015 17:17:39 +0200
> Subject: [PATCH] mov: reject zero bytes_per_frame with non-zero
>  samples_per_frame
> 
> In this case the mov demuxer can return a large number of empty packets.

LGTM

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150525/69d689b8/attachment.asc>