[FFmpeg-devel] [PATCH 1/2] mmaldec: add vc1 decoding support

[wm4]

On Fri, 6 Nov 2015 22:21:55 -0300
James Almer <jamrial at gmail.com> wrote:

> On 11/6/2015 12:15 PM, wm4 wrote:
> > ---
> >  configure              |  3 +++
> >  libavcodec/Makefile    |  1 +
> >  libavcodec/allcodecs.c |  2 ++
> >  libavcodec/mmaldec.c   | 12 ++++++++++++
> >  4 files changed, 18 insertions(+)
> > 
> > diff --git a/configure b/configure
> > index f770534..8c940a7 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2516,6 +2516,9 @@ vc1_vdpau_decoder_deps="vdpau"
> >  vc1_vdpau_decoder_select="vc1_decoder"
> >  vc1_vdpau_hwaccel_deps="vdpau"
> >  vc1_vdpau_hwaccel_select="vc1_decoder"
> > +vc1_mmal_decoder_deps="mmal"
> > +vc1_mmal_hwaccel_deps="mmal"
> > +vc1_mmal_decoder_select="vc1video_decoder"  
> 
> vc1_mmal_decoder_select="vc1_decoder"

Fixed locally. Anything else, or can I push?

> Also, judging by every other hwaccel, shouldn't you also add a
> vc1_mmal_hwaccel_select="vc1_decoder" line?

The h264 and mpeg2 mmal ones do not do this either. It probably doesn't
make sense to make them selectable, because the hwaccels exist only to
make utils.c ff_get_format happy. Selection at build time can be done
through the decoder configure options.