[FFmpeg-devel] [PATCH] avformat/mxfenc: Only store user comment related tags when needed

[Michael Niedermayer]

On Tue, Nov 10, 2015 at 07:37:28AM +0000, tim nicholson wrote:
> On 09/11/15 17:56, Michael Niedermayer wrote:
> > From: Michael Niedermayer <michael at niedermayer.cc>
> > 
> > Also support disabling them as they seem to cause problems to some
> > Users.
> > 
> > [..]
> > -    for (i = 0; i < local_tag_number; i++) {
> > +    for (i = 0; i < FF_ARRAY_ELEMS(mxf_local_tag_batch); i++) {
> >          avio_wb16(pb, mxf_local_tag_batch[i].local_tag);
> >          avio_write(pb, mxf_local_tag_batch[i].uid, 16);
> >      }
> > +    if (mxf->store_user_comments)
> > +        for (i = 0; i < FF_ARRAY_ELEMS(mxf_local_tag_batch); i++) {
> 
> Is this right? I expected:-
> 
> for (i = 0; i < FF_ARRAY_ELEMS(mxf_user_comments_local_tag); i++) {

oops, will send a new patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151110/04d456a0/attachment.sig>