[FFmpeg-devel] [PATCH] avformat/mxfenc: Only store user comment related tags when needed

[Michael Niedermayer]

On Mon, Nov 09, 2015 at 07:38:17PM +0100, Marton Balint wrote:
> 
> On Mon, 9 Nov 2015, Michael Niedermayer wrote:
> 
> >From: Michael Niedermayer <michael at niedermayer.cc>
> >
> >Also support disabling them as they seem to cause problems to some
> >Users.
> >
> >Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >---
> >doc/muxers.texi                      |   13 ++++++++
> >libavformat/mxfenc.c                 |   44 +++++++++++++++++++--------
> >tests/ref/seek/lavf-mxf              |   44 +++++++++++++--------------
> >tests/ref/seek/lavf-mxf_opatom_audio |   54 +++++++++++++++++-----------------
> >4 files changed, 93 insertions(+), 62 deletions(-)
> >
> >diff --git a/doc/muxers.texi b/doc/muxers.texi
> >index 06483fa..4cefe1e 100644
> >--- a/doc/muxers.texi
> >+++ b/doc/muxers.texi
> >@@ -874,6 +874,19 @@ ffmpeg -i file.mpg -c copy \
> >     -y out.ts
> >@end example
> >
> >+ at section mxf
> >+
> >+MXF muxer.
> >+
> >+ at subsection Options
> >+
> >+The muxer options are:
> >+
> >+ at table @option
> >+ at item store_user_comments @var{bool}
> >+Set if user comments should be stored if available (default) or never.
> 
> Could you add some examples to the docs where this cause problems? E.g.
> 
> Set this to never to avoid compatiblity problems with xxx video
> servers or yyy NLE-s.

yes, ill document this better as far as i understand it ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151110/cdc2911a/attachment.sig>