[FFmpeg-devel] [PATCH] movenc-test: Pad the packet data start with 0s

[Michael Niedermayer]

On Tue, Nov 17, 2015 at 04:00:30PM +0000, Derek Buitenhuis wrote:
> This way, it never starts with 0xFFF0, and never trips the
> ADTS "Detection" code in movenc.c.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
>  libavformat/movenc-test.c |  4 ++--
>  tests/ref/fate/movenc     | 40 ++++++++++++++++++++--------------------
>  2 files changed, 22 insertions(+), 22 deletions(-)
> 
> diff --git a/libavformat/movenc-test.c b/libavformat/movenc-test.c
> index 8132bab..ceaebca 100644
> --- a/libavformat/movenc-test.c
> +++ b/libavformat/movenc-test.c
> @@ -215,7 +215,7 @@ static void mux_frames(int n)
>      int end_frames = frames + n;
>      while (1) {
>          AVPacket pkt;
> -        uint8_t pktdata[4];
> +        uint8_t pktdata[8] = { 0 };
>          av_init_packet(&pkt);
>  
>          if (av_compare_ts(audio_dts, audio_st->time_base, video_dts, video_st->time_base) < 0) {

> @@ -257,7 +257,7 @@ static void mux_frames(int n)
>  
>          if (clear_duration)
>              pkt.duration = 0;
> -        AV_WB32(pktdata, pkt.pts);
> +        AV_WB32(pktdata + 4, pkt.pts);
>          pkt.data = pktdata;
>          pkt.size = 4;

this looks a bit strange
doesnt this write the PTS into bytes which are never used or read?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151118/be46cb12/attachment.sig>