[FFmpeg-devel] [PATCH 3/3] lavf/flvdec: use AVERROR_REDO instead of AVERROR(EAGAIN).

[Ronald S. Bultje]

Hi,

On Thu, Nov 26, 2015 at 3:08 PM, wm4 <nfxjfg at googlemail.com> wrote:

> On Thu, 26 Nov 2015 20:46:25 +0100
> Nicolas George <george at nsup.org> wrote:
>
> > Le sextidi 6 frimaire, an CCXXIV, wm4 a écrit :
> > > Better do the looping internal in flvdec.c (if there's no huge number
> > > of other demuxers which need this), instead of adding a new error code
> > > that is also part of the public API.
> >
> > There are a few, but not many. This was my first intent, but looping in
> the
> > framework is way more elegant and much cleaner design.
>
> I fail to see how letting such a workaround (required for flv) leak to
> common code is more elegant.


I +1 this design comment, I have some (...) reservations about adding
EAGAIN2 (which is really what this is) to our public API (which is really
what this is).

Ronald