[FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter
Ganesh Ajjanagadde
gajjanag at mit.edu
Sun Nov 29 00:21:27 CET 2015
On Sat, Nov 28, 2015 at 5:26 PM, Paul B Mahol <onemda at gmail.com> wrote:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
[...]
> + case SQUARE:
> + val = (phs < 0.5) ? -1 : +1;
Something I missed: consider using e.g FFSIGN(phs - 0.5) or FFSIGN(0.5
- phase), can't recall. This is actually important because if one
feeds in 0.5 exactly (which is exactly representable), val becomes
unitialized and hence garbage.
[...]
More information about the ffmpeg-devel
mailing list