[FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

[Claudio Freire]

On Mon, Nov 30, 2015 at 2:20 PM, Rostislav Pehlivanov
<atomnuker at gmail.com> wrote:
> On Mon, 2015-11-30 at 12:50 -0300, Claudio Freire wrote:
>> Also I don't see how a static var would help or even be correct here.
>> Perhaps you meant something else?
> static uint8_t cond1 = param1 && param2;
> static uint8_t cond2 = param3 && !param4;
> ...etc
> return cond1 && cond2;

I don't think the static there does what you think it does.

Just an:

int cond1 = ...;

Would be enough. Not even uint8_t is a win (the conversion to uint8_t
tends to be slower than leaving it at the native int register size).
Same with naming variables, that can tie the compiler's hands
regarding optimizations.

So, as before, I'll see what can be done. If it doesn't break any
optimizations and really makes things more readable I'll do that.