[FFmpeg-devel] [PATCH] avutil: runtime cpu detection for mips

[Shivraj Patil]

On Wed, Sep 30, 2015 at 02:21:18PM +0000, Shivraj Patil wrote:
> 
> On Wed, Sep 30, 2015 at 07:03:46PM +0530, shivraj.patil at imgtec.com wrote:
> > From: Shivraj Patil <shivraj.patil at imgtec.com>
> [...]
> 
> > +static int get_cpuinfo(uint32_t *hwcap) {
> > +    FILE *f = fopen("/proc/cpuinfo", "r");
> 
> under qemu i get this:
> 
> cpu_flags(raw) = 0x00000000
> cpu_flags_str(raw) =
> cpu_flags(effective) = 0x00000000
> cpu_flags_str(effective) =
> threads = 1 (cpu_count = 12)
> 
> IIUC this disables all cpu extensions
> is that intended ?
> (we currently only have loongson hardware to test so this would mean  
> an end to testing imgtec specific mips optimizations)
> 
> Shivraj:- cpu detection will not work for qemu, however we have tested it on mips hardware at our end.

iam not speaking about just this patch
but we have just qemu to test on imgtec - mips i can apply this patch but it means that in the future FFmpeg will then only be tested on loongson because you effectively disable our only way to test code on imgtec mips

its very strange that you want this

Shivraj:- I have got the concern with this patch and so request you to please discard it for now.
It will make more sense to resubmit (modified) at appropriate time in near future when MSA enabled devices are setup for testing.
Till the time requesting to keep the mips testing under QEMU as it is.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.