[FFmpeg-devel] [PATCH 07/15] lavfi/vf_select: remove looping on request_frame().

Michael Niedermayer michaelni at gmx.at
Fri Oct 2 23:04:55 CEST 2015


On Fri, Oct 02, 2015 at 05:13:18PM +0200, Nicolas George wrote:
> Signed-off-by: Nicolas George <george at nsup.org>
> ---
>  libavfilter/f_select.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c
> index 3e7cf78..7613ca1 100644
> --- a/libavfilter/f_select.c
> +++ b/libavfilter/f_select.c
> @@ -383,14 +383,8 @@ static int request_frame(AVFilterLink *outlink)
>      SelectContext *select = ctx->priv;
>      AVFilterLink *inlink = outlink->src->inputs[0];
>      int out_no = FF_OUTLINK_IDX(outlink);
> -
> -    do {
> -        int ret = ff_request_frame(inlink);
> -        if (ret < 0)
> -            return ret;
> -    } while (select->select_out != out_no);
> -
> -    return 0;
> +    int ret = ff_request_frame(inlink);
> +    return ret;

out_no and select become unused

no further comments from me

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151002/1d567253/attachment.sig>


More information about the ffmpeg-devel mailing list