[FFmpeg-devel] [PATCH] avcodec/apedec: fix bug introduced in commit d3e5fbb1406995e07fccbff3ca8c1e24f57a1f7b

[Ganesh Ajjanagadde]

On Sat, Oct 3, 2015 at 8:15 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Sat, Oct 3, 2015 at 9:11 AM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
>
>> On Sat, Oct 3, 2015 at 7:49 AM, Hendrik Leppkes <h.leppkes at gmail.com>
>> wrote:
>> > On Sat, Oct 3, 2015 at 2:33 PM, Ganesh Ajjanagadde <gajjanag at mit.edu>
>> wrote:
>> >> On Tue, Sep 29, 2015 at 8:25 PM, Ganesh Ajjanagadde <gajjanag at mit.edu>
>> wrote:
>> >>> On Tue, Sep 29, 2015 at 9:08 PM, Michael Niedermayer <michaelni at gmx.at>
>> wrote:
>> >>>> On Tue, Sep 29, 2015 at 07:27:03PM -0400, Ganesh Ajjanagadde wrote:
>> >>>>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> >>>>> ---
>> >>>>>  libavcodec/apedec.c | 2 +-
>> >>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>>>
>> >>>> breaks fate
>> >>>>
>> >>>> --- ./tests/ref/fate/lossless-monkeysaudio-399  2015-09-29
>> 13:42:22.893972599 +0200
>> >>>> +++ tests/data/fate/lossless-monkeysaudio-399   2015-09-30
>> 03:06:06.950988548 +0200
>> >>>> @@ -1 +1 @@
>> >>>> -a28d4e5f2192057f7d4bece870f40bd0
>> >>>> +df8663c29d7cd7268d6ae77edd742bb5
>> >>>> Test lossless-monkeysaudio-399 failed. Look at
>> tests/data/fate/lossless-monkeysaudio-399.err for details.
>> >>>> make: *** [fate-lossless-monkeysaudio-399] Error 1
>> >>>
>> >>> Weird, unfortunately for whatever reason my fate does not test this
>> >>> (though apedec gets compiled) so I can't reproduce. One suggestion I
>> >>> have is removing the U at the end, that will prevent any unforeseen
>> >>> signed/unsigned business which I thought was ok. Please change the
>> >>> author tag if you do this.
>> >>
>> >> updated patch removing the U; like I said my fate does not test it so
>> >> it only has been compile tested.
>> >>
>> >
>> > You should figure out whats wrong with your FATE, the ape test doesn't
>> > use anything special in particular, so if it isnt running, a bunch of
>> > others may also not be.
>>
>> The faq mentions something about fate-suite, and setting the --samples
>> configure flag.
>> First off, I don't understand why this is needed since I don't change
>> paths except the install path (--prefix=/usr).
>> Second, where is this "fate-suite", and why is it not part of the
>> FFmpeg source repository?
>>
>
> It's HUGE. HHUUUGGGGEEEE. And it's binary files. We don't want that to live
> in git, it's not the right place.

Ah, so the only ones that are part of the repository are the small
ones or the synthesized ones. That makes sense.

>
>
>> And lastly, how can I set this up correctly?
>
>
> configure --samples=/path/to/some/dir/with/lots/of/space, and then make
> fate-rsync to download samples (or refresh), and make fate to run it.

Thank you, an RTFM would also have been fine :).

>
> Ronald
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel