[FFmpeg-devel] [PATCH 1/2] avcodec/alacdec: split off decorrelate_stereo and append_extra_bits as alacdsp

[Michael Niedermayer]

On Sun, Oct 04, 2015 at 01:34:52PM -0300, James Almer wrote:
> On 10/4/2015 7:35 AM, Michael Niedermayer wrote:
> > On Sun, Oct 04, 2015 at 01:31:27AM -0300, James Almer wrote:
> >>> +        if (decorr_left_weight) {
> >>
> >> So while i was writing a checkasm unit i started looking at the possible
> >> values for this, and found out that apparently it's either 0 or 1.
> >> Since the function below is not called when it's 0, wouldn't that mean
> >> it's a pointless argument?
> >>
> >> I'll have to redo the asm function if that's the case, and change the
> >> prototype and boilerplate c version.
> > 
> > why would it only be 0 or 1 ?
> > (it sure could be in actual files but the syntax allows 8bit values)
> 
> Our encoder at least does as much (see alac_stereo_decorrelation() in
> alacenc.c). Haven't tried others, so unless someone that knows the spec
> chimes in I'll leave it as is.

there is a spec ?
i only know of soe reference source code and i looked yesterday
and it usesed the full 8 bits unless i missed something

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151004/78c95682/attachment.sig>