[FFmpeg-devel] [PATCH 5/5] dnxhddec: replace some 0s by DNXHD_VARIABLE

[tim nicholson]

On 02/10/15 20:00, Christophe Gisquet wrote:
> A series of 0 in a table can be confusing, and the corresponding checks
> strange, so using a macro instead of that magic is more readable.
> ---
>  libavcodec/dnxhddata.c | 10 +++++-----
>  libavcodec/dnxhddata.h |  3 +++
>  libavcodec/dnxhddec.c  |  6 ++++--
>  3 files changed, 12 insertions(+), 7 deletions(-)
> 
> [..]
> +/** Indicate that a CIDEntry value must be read in the bitstream */
> +#define DNXHD_VARIABLE 0
> +

I'm all for more readable, presumably atm its only ever 0 but may change
in the future, in which case some idea of what it represents may be
useful, I am sure the spec has more than one variable ;)

> [..]

-- 
Tim.
Key Fingerprint 38CF DB09 3ED0 F607 8B67 6CED 0C0B FC44 8B0B FC83