[FFmpeg-devel] [PATCH 1/3] dnxhddec: better support for 4:4:4

[Michael Niedermayer]

On Wed, Oct 07, 2015 at 08:08:39PM +0200, Christophe Gisquet wrote:
> 2015-10-07 10:32 GMT+02:00 Christophe Gisquet <christophe.gisquet at gmail.com>:
> >> this would allow ctx->bit_depth to be set but without initializing the
> >> dsp contexts
> >> subsequent runs would also skip init due to
> >> " if (ctx->bit_depth != old_bit_depth) {"
> >
> > Actually, other changes could trigger the issue, like
> > 4:2:2 10 bits -> 4:4:4 8 bits (unknown, unsupported) -> 4:2:2 8 bits.
> >
> > Setting ctx->bit_depth should probably be delayed to when the idcts are set.
> 
> Here's an updated patch.
> 
> -- 
> Christophe

>  dnxhddec.c |  109 ++++++++++++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 76 insertions(+), 33 deletions(-)
> e4c57c9185aa008518f0a72947534785ec20823e  0001-dnxhddec-better-support-for-4-4-4.patch
> From 9dbddfc7981312e1221c86e6399f716e6c3df972 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Sun, 4 Oct 2015 10:06:28 +0200
> Subject: [PATCH 1/3] dnxhddec: better support for 4:4:4
> 
> Profiles 1256 & 1270 (currently) signal at the frame header and MB
> levels the colorspace used, either RGB or YUV. While a MB-level
> varying colorspace is not supported, whether it is constant can be
> tracked so as to determine the exact colorspace.
> 
> This requires having bitdepth and the ACT and 4:4:4 flags, in turn
> needing the CID. Because setting those before having validated
> enough things may result in invalid/unset DSP fucntions, setting
> the bitdepth in the context is delayed.
> 
> It is not tested against a true RGB sequence, though.
> ---
>  libavcodec/dnxhddec.c | 109 +++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 76 insertions(+), 33 deletions(-)

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151007/761da409/attachment.sig>