[FFmpeg-devel] [PATCH] avcodec/webvttdec: Deal with WebVTT escapes
Ricardo Constantino
wiiaboo at gmail.com
Fri Oct 9 17:29:03 CEST 2015
Bare ampersand characters are still accepted, even though out-of-spec.
Also fixes adjacent tags not being parsed.
Fixes trac #4915
Signed-off-by: Ricardo Constantino <wiiaboo at gmail.com>
---
libavcodec/webvttdec.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/libavcodec/webvttdec.c b/libavcodec/webvttdec.c
index 1284a17..3b98e98 100644
--- a/libavcodec/webvttdec.c
+++ b/libavcodec/webvttdec.c
@@ -37,11 +37,14 @@ static const struct {
{"<b>", "{\\b1}"}, {"</b>", "{\\b0}"},
{"<u>", "{\\u1}"}, {"</u>", "{\\u0}"},
{"{", "\\{"}, {"}", "\\}"}, // escape to avoid ASS markup conflicts
+ {">", ">"}, {"<", "<"},
+ {"", ""}, {"", ""}, // FIXME: properly honor bidi marks
+ {"&", "&"}, {" ", " "},
};
static int webvtt_event_to_ass(AVBPrint *buf, const char *p)
{
- int i, skip = 0;
+ int i, again, skip = 0;
while (*p) {
@@ -51,13 +54,19 @@ static int webvtt_event_to_ass(AVBPrint *buf, const char *p)
if (!strncmp(p, from, len)) {
av_bprintf(buf, "%s", webvtt_tag_replace[i].to);
p += len;
+ again = 1;
break;
}
}
if (!*p)
break;
- if (*p == '<')
+ if (again) {
+ again = 0;
+ skip = 0;
+ continue;
+ }
+ else if (*p == '<')
skip = 1;
else if (*p == '>')
skip = 0;
--
2.6.0
More information about the ffmpeg-devel
mailing list