[FFmpeg-devel] [PATCH 2/2] pixblockdsp: Use memcpy for get_pixels_16_c

[Michael Niedermayer]

On Sat, Oct 17, 2015 at 06:05:46PM -0700, Timothy Gu wrote:
> Before:
>   15543 decicycles in get_pixels, 4193214 runs,   1090 skips
> After:
>    5713 decicycles in get_pixels, 8387564 runs,   1044 skips
> ---
>  libavcodec/pixblockdsp.c          | 38 ++++++++++++++++++++++++++++++++-----
>  libavcodec/pixblockdsp_template.c | 40 ---------------------------------------
>  2 files changed, 33 insertions(+), 45 deletions(-)
>  delete mode 100644 libavcodec/pixblockdsp_template.c

breaks fate:

--- ./tests/ref/vsynth/vsynth1-dnxhd-720p-10bit 2015-10-17 19:12:46.567154035 +0200
+++ tests/data/fate/vsynth1-dnxhd-720p-10bit    2015-10-20 17:13:03.600463343 +0200
@@ -1,4 +1,4 @@
-f8c4b7aa165a80df2485d526161290a3 *tests/data/fate/vsynth1-dnxhd-720p-10bit.dnxhd
+cb729072a15682440da8a443f922ac8c *tests/data/fate/vsynth1-dnxhd-720p-10bit.dnxhd
 2293760 tests/data/fate/vsynth1-dnxhd-720p-10bit.dnxhd
-87f1f0e074466facd3a9922ecc8311db *tests/data/fate/vsynth1-dnxhd-720p-10bit.out.rawvideo
-stddev:    6.23 PSNR: 32.23 MAXDIFF:   64 bytes:  7603200/   760320
+17bc71b58b687ffe06c13b99a5e55ac3 *tests/data/fate/vsynth1-dnxhd-720p-10bit.out.rawvideo
+stddev:   32.92 PSNR: 17.78 MAXDIFF:  211 bytes:  7603200/   760320
Test vsynth1-dnxhd-720p-10bit failed. Look at tests/data/fate/vsynth1-dnxhd-720p-10bit.err for details.
make: *** [fate-vsynth1-dnxhd-720p-10bit] Error 1
make: *** Waiting for unfinished jobs....
--- ./tests/ref/vsynth/vsynth1-dnxhd-1080i-10bit        2015-10-17 19:12:46.567154035 +0200
+++ tests/data/fate/vsynth1-dnxhd-1080i-10bit   2015-10-20 17:13:03.836463348 +0200
@@ -1,4 +1,4 @@
-f562845d1848bf5d3e524b418b742e01 *tests/data/fate/vsynth1-dnxhd-1080i-10bit.mov
+90be2539a8ad5475cdda2421874ccfaa *tests/data/fate/vsynth1-dnxhd-1080i-10bit.mov
 4588391 tests/data/fate/vsynth1-dnxhd-1080i-10bit.mov
-31032fcb7e6af79daaac02288254c6d6 *tests/data/fate/vsynth1-dnxhd-1080i-10bit.out.rawvideo
-stddev:    5.69 PSNR: 33.02 MAXDIFF:   55 bytes:  7603200/   760320
+50a342f03d5b00a51b65804814c857ff *tests/data/fate/vsynth1-dnxhd-1080i-10bit.out.rawvideo
+stddev:   22.26 PSNR: 21.18 MAXDIFF:  233 bytes:  7603200/   760320
Test vsynth1-dnxhd-1080i-10bit failed. Look at tests/data/fate/vsynth1-dnxhd-1080i-10bit.err for details.
make: *** [fate-vsynth1-dnxhd-1080i-10bit] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151020/d384fd66/attachment.sig>